chore: Upgrade to Java 11 #393
Conversation
| @@ -88,15 +88,8 @@ lazy val root = (project in file(".")) | |||
| Universal / javaOptions ++= Seq( | |||
| "-Dconfig.file=/etc/gu/janus.conf", // for PROD, overridden by local sbt file | |||
| "-Dpidfile.path=/dev/null", | |||
| "-J-XX:MaxRAMFraction=2", | |||
There was a problem hiding this comment.
The error in the last attempt was thought to be caused by "-J-XX:+PrintGCDateStamps", and there were warnings caused by the RAM fraction options-J-XX:MaxRAMFraction=2 and -J-XX:InitialRAMFraction=2. The RAM fractions have been replaced with initial heap size(Xms) and max heap size (Xmx). After discussion with @adamnfish and @jacobwinch all the advanced options (-XX) were deemed unnecessary and thus removed.
build.sbt
Outdated
| "-J-Xloggc:/var/log/${packageName.value}/gc.log", | ||
| "-J-XX:+UseCompressedOops", | ||
| "-J-XX:+UseStringDeduplication" | ||
| "-J-Xms2048m", |
There was a problem hiding this comment.
This application is running on an instance that has 2GB of RAM in total, so I think this value (and the one below) are too high. We need to leave some room for the OS as well! At the moment, the JVM will happily consume up to 2GB of RAM, and in doing so at some point may request memory that the OS does not have space to offer. This will cause an OOM crash.
The RAMFRaction setting was 2, which means this is currently using half the available RAM. Let's start by setting it to the same, 1024m or 1g?
This is a re-attempt to upgrade Java to v11. This was attempted in #379 and reverted in #381.
Requires: https://github.com/guardian/janus/pull/3947 which should be merged first, as Java 11 is backwards compatible with Java 8.