This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
feat(ophan): Add key_event_card ophan component type
#348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joecowton1
force-pushed
the
jc/add-key-event-card-ophan-component-type
branch
from
85f014a
to
5caa09f
Compare
marjisound
approved these changes
May 3, 2022
sndrs
approved these changes
May 4, 2022
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
SHession
approved these changes
May 4, 2022
joecowton1
added a commit
that referenced
this pull request
May 10, 2022
This reverts commit 92668cf.
joecowton1
added a commit
that referenced
this pull request
May 10, 2022
joecowton1
added a commit
that referenced
this pull request
May 10, 2022
joecowton1
added a commit
that referenced
this pull request
May 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR adds a
KEY_EVENT_CARDOphan component type.Why?
We're in the process of creating a new key events timeline carousel, the first step of which has been to create new key event cards: guardian/dotcom-rendering#4696
In order to track clicks on these new cards, we need a new componentType.
The corresponding PR in Ophan is here: https://github.com/guardian/ophan/pull/4617