Make android offer tags an array

guardian · Jun 6, 2024 · 342d5a0 · 342d5a0
1 parent a59435a
commit 342d5a0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/membership-attribute-service/app/models/FeastApp.scala b/membership-attribute-service/app/models/FeastApp.scala
@@ -47,8 +47,8 @@ object FeastApp {
       else
         RegularSubscription,
     )
-  def getFeastAndroidOfferTags(attributes: Attributes): Option[String] =
+  def getFeastAndroidOfferTags(attributes: Attributes): Option[List[String]] =
     if (shouldShowSubscriptionOptions(attributes) && shouldGetFreeTrial(attributes))
-      Some(AndroidOfferTags.ExtendedTrial)
+      Some(List(AndroidOfferTags.ExtendedTrial))
     else None
 }
diff --git a/membership-attribute-service/test/controllers/AttributeControllerTest.scala b/membership-attribute-service/test/controllers/AttributeControllerTest.scala
@@ -423,7 +423,7 @@ class AttributeControllerTest extends Specification with AfterAll with Idiomatic
              |  "userId": "$userWithRecurringContributionUserId",
              |  "showSupportMessaging": false,
              |  "feastIosSubscriptionGroup": "${FeastApp.IosSubscriptionGroupIds.ExtendedTrial}",
-             |  "feastAndroidOfferTags": "${FeastApp.AndroidOfferTags.ExtendedTrial}",
+             |  "feastAndroidOfferTags": ["${FeastApp.AndroidOfferTags.ExtendedTrial}"],
              |  "recurringContributionPaymentPlan":"Monthly Contribution",
              |  "recurringContributionAcquisitionDate":"$dateBeforeFeastLaunch",
              |  "contentAccess": {
@@ -455,7 +455,7 @@ class AttributeControllerTest extends Specification with AfterAll with Idiomatic
              |  "liveAppSubscriptionExpiryDate":"${dateTimeInTheFuture.toLocalDate}",
              |  "showSupportMessaging": false,
              |  "feastIosSubscriptionGroup": "${FeastApp.IosSubscriptionGroupIds.ExtendedTrial}",
-             |  "feastAndroidOfferTags": "${FeastApp.AndroidOfferTags.ExtendedTrial}",
+             |  "feastAndroidOfferTags": ["${FeastApp.AndroidOfferTags.ExtendedTrial}"],
              |  "contentAccess": {
              |    "member": false,
              |    "paidMember": false,
@@ -485,7 +485,7 @@ class AttributeControllerTest extends Specification with AfterAll with Idiomatic
              |  "userId": "$userWithNewspaperUserId",
              |  "paperSubscriptionExpiryDate":"${dateTimeInTheFuture.toLocalDate}",
              |  "feastIosSubscriptionGroup": "${FeastApp.IosSubscriptionGroupIds.ExtendedTrial}",
-             |  "feastAndroidOfferTags": "${FeastApp.AndroidOfferTags.ExtendedTrial}",
+             |  "feastAndroidOfferTags": ["${FeastApp.AndroidOfferTags.ExtendedTrial}"],
              |  "showSupportMessaging": false,
              |  "contentAccess": {
              |    "member": false,
@@ -547,7 +547,7 @@ class AttributeControllerTest extends Specification with AfterAll with Idiomatic
              |  "guardianWeeklyExpiryDate":"${dateTimeInTheFuture.toLocalDate}",
              |  "showSupportMessaging": false,
              |  "feastIosSubscriptionGroup": "${FeastApp.IosSubscriptionGroupIds.ExtendedTrial}",
-             |  "feastAndroidOfferTags": "${FeastApp.AndroidOfferTags.ExtendedTrial}",
+             |  "feastAndroidOfferTags": ["${FeastApp.AndroidOfferTags.ExtendedTrial}"],
              |  "contentAccess": {
              |    "member": false,
              |    "paidMember": false,