Rename this endpoint to something more generic

guardian · May 20, 2024 · fcf04d5 · fcf04d5
1 parent 3ee4cb0
commit fcf04d5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/membership-attribute-service/app/controllers/AttributeController.scala b/membership-attribute-service/app/controllers/AttributeController.scala
@@ -222,15 +222,15 @@ class AttributeController(
     Attributes.jsAttributesWrites.writes(attributes) ++ encryptedUserId
   }
 
-  def attributesWithEncryptedUserId =
+  def attributesForApps =
     lookup(
-      endpointDescription = "attributesWithEncryptedUserId",
+      endpointDescription = "attributesForApps",
       onSuccessMember = attrs => Ok(augmentWithEncryptedUserId(attrs)),
       onSuccessSupporter = attrs => Ok(augmentWithEncryptedUserId(attrs)),
       onNotFound = notFound,
       sendAttributesIfNotFound = true,
       requiredScopes = List(readSelf),
-      metricName = "GET /user-attributes/me/with-encrypted-user-id",
+      metricName = "GET /user-attributes/me/apps",
       useBatchedMetrics = true,
     )
 

diff --git a/membership-attribute-service/conf/routes b/membership-attribute-service/conf/routes
@@ -1,7 +1,7 @@
 GET         /healthcheck                                                        controllers.HealthCheckController.healthCheck()
 
 GET         /user-attributes/me                                                 controllers.AttributeController.attributes
-GET         /user-attributes/me/with-encrypted-user-id                          controllers.AttributeController.attributesWithEncryptedUserId
+GET         /user-attributes/me/apps                                            controllers.AttributeController.attributesForApps
 
 GET         /user-attributes/me/existing-payment-options                        controllers.ExistingPaymentOptionsController.existingPaymentOptions(currencyFilter: Option[String])
 

diff --git a/membership-attribute-service/test/controllers/AttributeControllerTest.scala b/membership-attribute-service/test/controllers/AttributeControllerTest.scala
@@ -589,9 +589,9 @@ class AttributeControllerTest extends Specification with AfterAll with Idiomatic
 
     }
 
-    "the attributeWithEncryptedUserId returns the correct attributes plus encryptedUserId" in {
+    "attributesForApps returns the correct attributes plus encryptedUserId" in {
       val req = FakeRequest().withCookies(supporterPlusWithGuardianWeeklyCookie)
-      val result = controller.attributesWithEncryptedUserId(req)
+      val result = controller.attributesForApps(req)
 
       status(result) shouldEqual OK
       val jsonBody = contentAsJson(result)