Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename data types to reflect zuora's naming better #1076

Merged
merged 2 commits into from
May 21, 2024
Merged

rename data types to reflect zuora's naming better #1076

merged 2 commits into from
May 21, 2024

Conversation

johnduffell
Copy link
Member

@johnduffell johnduffell commented May 21, 2024 •
edited

separate PR for the naming strategy suggested by @rupertbates in #1073 (comment)

renames as follows

SubscriptionPlan -> RatePlan
SingleCharge -> RatePlanCharge
ChargeList -> RatePlanChargeList
CatalogPlan -> ProductRatePlan

@johnduffell johnduffell mentioned this pull request May 21, 2024
Merged
rupertbates
rupertbates approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@rupertbates rupertbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from jd-remove-pending-freeplan to main May 21, 2024 15:01
@johnduffell johnduffell merged commit aed658c into main May 21, 2024
1 check passed
@johnduffell johnduffell deleted the jd-rename-sub-types branch May 21, 2024 15:14
@prout-bot
Copy link

Seen on PROD (merged by @johnduffell 5 minutes and 24 seconds ago) Please check your changes!

Sentry Release: members-data-api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rupertbates rupertbates rupertbates approved these changes

Assignees
No one assigned
Labels
Seen-on-PROD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnduffell @prout-bot @rupertbates