This repository has been archived by the owner on Nov 23, 2023. It is now read-only.
Refactor zuora service implementation #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 30, 2015 18:17
also add text/plain header manually
| refreshAlteringFuture <- agent.alter { currentRefresh => | ||
| if (currentRefresh.isCompleted) f else currentRefresh | ||
| } | ||
| refreshFuture <- refreshAlteringFuture |
There was a problem hiding this comment.
misleading name here I think; the type of refreshFuture is not Future[T]
|
👍 bar the comment |
afiore
pushed a commit
that referenced
this pull request
Aug 4, 2015
Refactor zuora service implementation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
ZuoraServiceinitialises a number ofScheduledTaskswith a "blank" authentication value. This is not ideal, as it means that for a small time window, the application is not capable to talk to Zuora. In this specific caseScheduledTaskalso makes composing async operations in the right order harder than necessary, forcing us to use fiddly callbacks to ensure that operations happen in the right order.Following a suggestion from @rtyley, I have repurposed a pattern from Prout. This consists in wrapping a future value into an Akka agent, which in turn gets periodically refreshed by the Actor system's scheduler (see
utils.FutureSupplier).Note: This PR branches off #647
@tudorraul @rtyley