Skip to content

Commit

Permalink
Merge pull request #81 from guardian/fairground/add-card-type-for-hig…
Browse files Browse the repository at this point in the history
…hlights-container

Add a card type and a collection design for new masthead design
  • Loading branch information
waisingyiu committed May 21, 2024
2 parents 979cf1f + e9f53d1 commit c23d394
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 1 deletion.
13 changes: 12 additions & 1 deletion proto/blueprint.proto
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ message Collection {
* MAPI doesn't support the specific content that's included in the
* collection. In this case it's assumed the client will hide the entire
* collection from the reader.
* Another reason for empty rows is that the collection is a titlepiece.
* In fact, we must keep the rows empty in this case in order not to break
* old versions of app that were built before titlepiece is introduced.
*/
repeated Row rows = 4;
optional string title = 5;
Expand Down Expand Up @@ -57,7 +60,9 @@ message Collection {

/**
* For some design on specific types of collections, we want to show
* an image and a description in the collection header.
* an image and a description in the collection header. This field is
* used for award text if the collection design is
* COLLECTION_DESIGN_TITLEPIECE.
*/
optional string description = 11;
optional Image image = 12;
Expand All @@ -69,6 +74,7 @@ message Collection {
COLLECTION_DESIGN_UNSPECIFIED = 0;
COLLECTION_DESIGN_REGULAR = 1;
COLLECTION_DESIGN_PODCAST = 2;
COLLECTION_DESIGN_TITLEPIECE = 3;
}
optional CollectionDesign design = 13;
}
Expand Down Expand Up @@ -394,6 +400,11 @@ message Card {
* series tag.
*/
CARD_TYPE_PODCAST_SERIES = 9;
/**
* A card with a different design. It is intended for highlights
* containers.
*/
CARD_TYPE_HIGHLIGHT = 10;
}
CardType type = 1;
Article article = 2;
Expand Down
8 changes: 8 additions & 0 deletions proto/proto.lock
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@
{
"name": "COLLECTION_DESIGN_PODCAST",
"integer": 2
},
{
"name": "COLLECTION_DESIGN_TITLEPIECE",
"integer": 3
}
]
},
Expand Down Expand Up @@ -101,6 +105,10 @@
{
"name": "CARD_TYPE_PODCAST_SERIES",
"integer": 9
},
{
"name": "CARD_TYPE_HIGHLIGHT",
"integer": 10
}
]
},
Expand Down

0 comments on commit c23d394

Please sign in to comment.