Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace outdated font files #812

Merged
merged 1 commit into from Jul 30, 2018
Merged

Replace outdated font files #812

merged 1 commit into from Jul 30, 2018

Conversation

duarte
Copy link
Contributor

@duarte duarte commented Jul 30, 2018

Updates Guardian Headline font files to the latest version…

CC @paperboyo

@duarte duarte requested a review from NataliaLKB July 30, 2018 11:23
@paperboyo
Copy link

Thanks, @duarte!

@mchv
Copy link
Member

mchv commented Jul 30, 2018

@paperboyo I think this is one step completed of guardian/frontend#19550

@paperboyo
Copy link

Unfortunately, no @mchv. This is just fixing omission (using beta version of the GH Guardian Headline fonts here). The above PR is about upgrading Guardian Egyptian and Sans Text fonts: it is separate job.

@duarte duarte merged commit 40970b3 into master Jul 30, 2018
@maxspencer
Copy link
Contributor

We no longer use the fonts packaged with the templates, we bundle them natively. I can take the files included here and make the same change in the android-news-app repo.

@paperboyo
Copy link

We no longer use the fonts packaged with the templates, we bundle them natively.

Thanks for letting me know, @maxspencer, very useful! Could you also synchronise with iOS (and, IMHO, with dotcom) on #813 (comment), please? Ideally, we would have just one set, but if you Guys decide differently, we should have two, not three!

Plus, just a small win-wink-nudge-nudge about mentioned guardian/frontend#19550.

@alfavata
Copy link
Contributor

alfavata commented Jul 30, 2018

Yes please, we'd be very keen to share our fonts with the template layer as well!
(I believe @jorgeazevedo has this on his roadmap too)

@alfavata alfavata deleted the dcg-replace-fonts branch July 30, 2018 16:27
@alfavata
Copy link
Contributor

I've created a Tech Debt ticket in our Jira backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants