Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GuardianTextEgyptian everywhere (AA-561 and GLA-633) #843

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

maxspencer
Copy link
Contributor

This PR builds upon #842, it:

  • includes the GuardianTextEgyptian font files in the templates repo,
  • modifies the SCSS to use those fonts on both platforms,
  • removes their old equivalents (egyptiantext-*.otf).

This PR should not be merged until iOS are happy with the changes and have had chance to test them.

@webb04
Copy link
Contributor

webb04 commented Feb 26, 2019

@maxspencer should this be merged?

@maxspencer
Copy link
Contributor Author

@webb04 I think so, but I'm confused because it seems that the previous PR #842 has been reverted now (looking at the diff here). It would still be right to check that this change is OK with iOS as it effects them.

@JamieB-gu
Copy link
Contributor

@maxspencer can we close this?

@maxspencer
Copy link
Contributor Author

@JamieB-gu what a blast from the past - Ideally we'd merge it to get rid of those old font names, but if it's causing you trouble then feel free to close.

@JamieB-gu
Copy link
Contributor

JamieB-gu commented Oct 9, 2020

It would still be right to check that this change is OK with iOS as it effects them.

@SLambrakis @faresite @dbk78 @aoifemcl15 @GiuliaAriu what do you think?

@maxspencer
Copy link
Contributor Author

@JamieB-gu I am looking through my old open PRs in prep for leaving. I think we should merge this one, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants