Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scala Steward by allowing building under Java 21 #22

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

rtyley
Copy link
Member

@rtyley rtyley commented Mar 20, 2024

Scala Steward can't run on this repo until it allows building under Java 21, due to guardian/scala-steward-public-repos#67 ... we're now running our Scala Steward workflow with Java 21 LTS, which means that all projects that want to have Scala Steward updates (like this one) need to be able to build under Java 21 (even if the projects are still running in production on Java 8).

Being able to build with Java 21 requires using recent versions of Scala (2.12.18+) and sbt (1.9.0+) - for this repo, all that's needed is a bump of sbt version!

(unfortunately the Scala Steward run failing affects everyone, see guardian/scala-steward-public-repos#60 - so I've removed mobile-logstash-encoder from Scala Steward until this PR is merged)

Scala Steward can't run on this repo until it allows building under Java 21, due to
guardian/scala-steward-public-repos#67 ... we're now running
our Scala Steward workflow with Java 21 LTS, which means that all projects that want
to have Scala Steward updates (like this one) need to be able to build under Java 21
(even if the projects are still _running_ in production on Java 8).

Being able to build with Java 21 [requires](https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html#jdk-21-compatibility-notes)
using recent versions of Scala (2.12.18+) and sbt (1.9.0+) - for this repo, all that's
needed is a bump of sbt version!
@rtyley rtyley requested a review from a team March 20, 2024 12:24
Copy link
Contributor

@waisingyiu waisingyiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rtyley rtyley merged commit e2abe78 into master Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants