MSS-554: Adding instance id #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markrichardsg
requested review from
alexduf,
NathanielBennett and
davidfurey
alexduf
reviewed
Nov 30, 2018
| case awsIdentity: AwsIdentity => Map( | ||
| "app" -> awsIdentity.app, | ||
| "stack" -> awsIdentity.stack, | ||
| "stage" -> awsIdentity.stage | ||
| ) | ||
| case _ => Map("app" -> defaultAppName) | ||
| }).mapValues(JsString)) | ||
| }) ++ Option(EC2MetadataUtils.getInstanceId).map("ec2_instance" -> _)).mapValues(JsString)) |
There was a problem hiding this comment.
I don't know if that method is cached, would it be safer to have a private attribute to store the instance ID at the class level, and re-use that attribute upon later calls?
I'm worried this actually does some sort of processing each time
There was a problem hiding this comment.
whoAmI already calls getInstanceId so this problem would already exist.
However, to be safe, I've turned the whole app stack stage object into a lazy val
alexduf
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.