Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVE-4538 Restrict JVM tiered compilation level to 1 for harvester #752

Merged
merged 3 commits into from
Sep 14, 2022

Conversation

waisingyiu
Copy link
Contributor

@waisingyiu waisingyiu commented Sep 12, 2022

What does this change?

We have experimented with the JVM settings about tiered compilation level in #756. The test results suggest that restricting the tiered compilation level to 1 is likely to improve the overall duration of harvester lambda.

This PR applies this JVM setting to the harvester lambda function via an environment variable.

How to test

This PR does not change any business logics.

We ran performance tests on CODE to evaluate the impact of this JVM setting.

How can we measure success?

We measure success using the 90in2min indicator, which is the percentage of recipients who are able to receive the notification under 2 mins.

Have we considered potential risks?

It may give poorer performance as the configuration and the workload are different in PROD from CODE, but there is no evidence to indicate so.

In any events, we can revert this PR to restore to the original settings.

Copy link

@groakland groakland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waisingyiu waisingyiu changed the title Set JVM tiered compilation level to 1 LIVE-4538 Restrict JVM tiered compilation level to 1 for harvester Sep 14, 2022
Copy link

@groakland groakland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waisingyiu waisingyiu merged commit 3aac18e into main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants