Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade cdk libs #110

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Upgrade cdk libs #110

merged 2 commits into from
Apr 17, 2024

Conversation

lindseydew
Copy link
Contributor

@lindseydew lindseydew commented Apr 10, 2024 •
edited
Loading

What does this change?

This upgrade the guardian cdk library and the aws cdk libs, ahead of an upgrade to Java 21 which is needed to be able to use the JAVA_21 enum.

How to test

This has been regression tested on CODE

  • Able to read articles
  • Able to add articles
  • Able to remove articles
  • Able to delete a user record

How can we measure success?

Have we considered potential risks?

Images

Accessibility

Base automatically changed from ld/run-s4l-locally to main April 16, 2024 16:34
aracho1
aracho1 approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@aracho1 aracho1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested locally and everything seems to run fine 👍 I've had to make some local config changes but will raise that as a separate PR

@lindseydew lindseydew merged commit 294a3fb into main Apr 17, 2024
2 checks passed
@lindseydew lindseydew deleted the ld/upgrade-cdk-libs branch April 17, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aracho1 aracho1 aracho1 approved these changes

@waisingyiu waisingyiu Awaiting requested review from waisingyiu

@rtyley rtyley Awaiting requested review from rtyley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lindseydew @aracho1