Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump identity-auth-core to 2.23 #113

Merged
merged 5 commits into from
Jun 5, 2024
Merged

bump identity-auth-core to 2.23 #113

merged 5 commits into from
Jun 5, 2024

Conversation

aracho1
Copy link
Contributor

@aracho1 aracho1 commented Apr 30, 2024

What does this change?

Bump identity-auth-core to the latest 4.25 which uses the required bouncy castle version (1.78)

Copy link
Contributor

@lindseydew lindseydew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good. Are you able to validate this version uses the desired version of bouncy castle (1.78)?

You can check this by running an sbt dependencyBrowseTree and searching for the jar in the html.

I would also suggest doing a quick sanity check on CODE to make sure the auth still works

@aracho1
Copy link
Contributor Author

aracho1 commented Jun 5, 2024

4.25 is now available for identity-auth-core which uses bouncy castle 1.78 so I've bumped it

Copy link
Contributor

@lindseydew lindseydew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍

@aracho1 aracho1 merged commit dd6efec into main Jun 5, 2024
2 checks passed
@aracho1 aracho1 deleted the bump-identity-lib branch June 5, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants