Build for play 2.9 and 3.0; drop play 2.7 #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Settings set in project/*.sbt will affect compilation of the build.sbt file, so setting -deprecation here will report deprecation warnings when running sbt
The `key in scope` syntax is replaced by `scope / key`
The `ThisBuild` scope means that the setting is applied as a fallback for each subproject - it doesn't really make sense to apply in the `commonSettings` block which is applied to each subproject individually.
This still exists but is not really used any more - all artifacts can be found on Maven Central.
panda doesn't use it, so don't enable it
These projects won't get released, and each subproject which will, already has sonatypeReleaseSettings applied, so this is unnecessary.
See panda-hmac for an existing example
panda-play-2_7 and 2_8 always had the same source code, so it was a shame that they were always duplicated. Going forward, where divergence isn't needed, have both projects point to the same sources.
|
snapshots published as 1.4.0-SNAPSHOT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
panda will be one of the first blockers to trying a play upgrade on another tool
I haven't yet tried a snapshot of this, which will be next step before requesting review and publishing thisreleased as 1.4.0-SNAPSHOTAlso includes a bit of a restructure of the repo - updated build.sbt, trying a hack to remove the copy/paste of the panda-play source codes, etc.
I've not yet included Scala 3 builds - we'll need to get to the new play versions before we can do that upgrade, but I'll give it a try soon anyway - looks less trivial since there's dependencies that aren't available for scala 3 :( but if I understand right we can always use 2.13 builds of panda on scala 3 projects anyway, so I don't feel any need to rush into setting up that build