Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update play-secret-rotation with CSRF fix #223

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

rtyley
Copy link
Member

@rtyley rtyley commented Apr 4, 2024

This updates our version of play-secret-rotation to the version that fixes guardian/play-secret-rotation#445 with PR guardian/play-secret-rotation#446.

Re-releasing play-googleauth with this update is probably not essential - it looks like the already-released version v6.0.0 of play-googleauth works just fine with it, they are not binary-incompatible - but I guess it's nice to have them all compiled against the nicest version of the code.

@rtyley rtyley force-pushed the update-play-secret-rotation branch from 947f367 to a2a8cca Compare April 4, 2024 15:51
@rtyley rtyley marked this pull request as ready for review April 4, 2024 15:51
@rtyley rtyley merged commit e6d038b into main Apr 4, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSRFTokenSigner freezes its copy of the secret on startup, leads to unpredictable CSRF token rejection
1 participant