Add Scala 2.13 support everywhere we can (ie Play 2.7, but not Play 2.6) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley
force-pushed
the
add-scala-2.13-support
branch
from
5f6c9ed
to
62e8312
Compare
This project compiles with Scala 2.12 by default, but now additionally can cross-compile to Scala 2.13 almost everywhere (not Play 2.6 because that never supported Scala 2.13). * Use `Iterable` in preference to the deprecated `Traversable` trait https://www.scala-lang.org/blog/2017/02/28/collections-rework.html#traversable-and-iterable https://www.scala-lang.org/blog/2018/06/13/scala-213-collections.html#iterable-is-the-top-collection-type * `scaffeine` & `scalatest` both updated to cross-compiled versions Additional sbt changes: * Use the latest version of sbt, which is faster at downloading dependencies! https://www.lightbend.com/blog/sbt-1.3.0-release * Use the latest version of `sbt-sonatype`, which has improved upload times into sonatype by using bundling! xerial/sbt-sonatype#89
rtyley
force-pushed
the
add-scala-2.13-support
branch
from
62e8312
to
feb6379
Compare
rtyley
added a commit
to guardian/play-googleauth
that referenced
this pull request
Oct 6, 2019
This project compiles with Scala 2.12 by default, but now additionally can cross-compile to Scala 2.13 for the versions of Play that support it (ie Play 2.7, but not Play 2.6). * `cats-core` & `scalatest` both updated to cross-compiled versions * `play-secret-rotation` updated to cross-compiled version guardian/play-secret-rotation#9
rtyley
added a commit
to guardian/play-googleauth
that referenced
this pull request
Oct 15, 2019
This project compiles with Scala 2.12 by default, but now additionally can cross-compile to Scala 2.13 for the versions of Play that support it (ie Play 2.7, but not Play 2.6). * `cats-core` & `scalatest` both updated to cross-compiled versions * `play-secret-rotation` updated to cross-compiled version guardian/play-secret-rotation#9
rtyley
added a commit
that referenced
this pull request
Aug 19, 2020
This change retains support for Play v2.6 & v2.7, as happily the code for `RotatingSecretComponents` is compatible with all 3 versions of Play! We were lucky! Pleasantly small diff here, due to the refactoring work that went into these two prior PRs: * #8 ...supporting Play 2.7 * #9 ...supporting Scala 2.13 everywhere that was possible
rtyley
added a commit
that referenced
this pull request
Aug 19, 2020
This change retains support for Play v2.6 & v2.7, as happily the code for `RotatingSecretComponents` is compatible with all 3 versions of Play! We were lucky! Pleasantly small diff here, due to the refactoring work that went into these two prior PRs: * #8 ...supporting Play 2.7 * #9 ...supporting Scala 2.13 everywhere that was possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project compiles with Scala 2.12 by default, but now additionally can cross-compile to Scala 2.13 almost everywhere (not Play 2.6 because that never supported Scala 2.13).
Iterablein preference to the deprecatedTraversabletraithttps://www.scala-lang.org/blog/2017/02/28/collections-rework.html#traversable-and-iterable
https://www.scala-lang.org/blog/2018/06/13/scala-213-collections.html#iterable-is-the-top-collection-type
scaffeine&scalatestboth updated to cross-compiled versionsAdditional sbt changes:
https://www.lightbend.com/blog/sbt-1.3.0-release
sbt-sonatype, which has improved upload times into sonatype by using bundling!Support bundle upload xerial/sbt-sonatype#89