feat: Improve label accessibility #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathonherbert
changed the title
|
cc. @marjisound and @abeddow91 – I will rebase #275 on this to enable us to add the appropriate tests for |
…ent's field data (#275) * Add onRemove handler to createReactElementSpec * feat: generate field values and pass to onRemove * fix: demo type * Add getElementData fn to consumer, and apply to onRemove * revert the change of using function syntax for ElementWrapper * Add test to verify onRemove callback passes field values Co-authored-by: Jonathon Herbert <jonathon.herbert@guardian.co.uk> Co-authored-by: Marjan Kalanaki <marjan.kalanaki@guardian.co.uk>
abeddow91
approved these changes
Nov 10, 2022
|
🎉 This PR is included in version 5.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
#275 requires some React-based unit tests, but in order for
testing-libraryto pass tests using our React wrappers, our accessibility story for labels needed to be improved, or we get the error:(How lovely for a testing library to point that out!)
This PR adds a test that verifies the accessibility of our labels by proxy, and adds the functionality that satisfies the test. Because we cannot add a
forattribute to our label (contenteditableelements cannot be addressed by this attribute per the spec), we add an a tag with a link to simulate the usual label behaviour – clicking on the label should give a pointer on hover, and focus the field input on click.How to test