Refactor: remove the consumer argument from createEmbedSpec
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathonherbert
force-pushed
the
jsh/consumer-refactor
branch
from
fa2856d
to
bb30a56
Compare
jonathonherbert
changed the title
createEmbedSpec
jonathonherbert
force-pushed
the
jsh/consumer-refactor
branch
from
bb30a56
to
fa0f24f
Compare
jonathonherbert
force-pushed
the
jsh/consumer-refactor
branch
from
fa0f24f
to
970210d
Compare
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Removes the consumer function that's passed through
createEmbedSpec. It's not used bycreateEmbedSpec, and is necessarily already in scope in the consumer context – so we don't need it as an argument. This simplifies the signature ofcreateEmbedSpec.How to test
This is a no-op – test should pass as before.