Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'how it works' docs #321

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Add 'how it works' docs #321

merged 3 commits into from
Nov 21, 2023

Conversation

jonathonherbert
Copy link
Contributor

What does this change?

Adds a 'How it works' section, a table of contents (the readme is now quite large), and cleans up some redundant documentation.

'How it works' just details with some setup and the NodeSpec generation for now. I've left placeholders for two parts that I think will be useful.

How to test

Have a read. Useful? Comments?

Copy link
Member

@davidfurey davidfurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

The `author__books` content expression, however, would be `"author__book*"` – as a repeater field, `author__books` can contain 0-many `author__book` nodes.

Finally, leaf nodes must represent user data in some way. There are two main ways of storing data in a ProseMirror Node:
- As node content. This is used whenever we want to express content types that are native to ProseMirror – for example, rich or plain text. The content expressions described above describe what sort of content a Node can contain. Data represented this way can be treated as part of the Prosemirror document – [`Selections`(https://prosemirror.net/docs/ref/#state.Selection)] and [`Decorations`](https://prosemirror.net/docs/ref/#view.Decoration), for example, will work as expected, and updates to this content can be incremental, which is important for collaborative editing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selections link isn't formatted correctly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 a67bda0

docs/how-it-works.md Outdated Show resolved Hide resolved
@jonathonherbert jonathonherbert merged commit 31fcc33 into main Nov 21, 2023
2 checks passed
@jonathonherbert jonathonherbert deleted the jsh/how-it-works-1 branch November 21, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants