Enforce repeater has minChildren nodes in schema #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhystmills
approved these changes
Feb 5, 2024
This fixes a bug where you can 'delete' an element that requires one child, putting it in a broken state Co-authored-by: Rhys Mills <34686302+rhystmills@users.noreply.github.com>
Fweddi
force-pushed
the
fp/rm/fix-repeater-schema-constraints
branch
from
01ce2dc
to
2f56805
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked on with @rhystmills.
This fixes a bug where you can 'delete' an element that requires one child, putting it in a broken state.
How to test
Publish the ProseMirror library locally and test in a consumer (e.g. Composer) where there is a repeater element with a
minChildrenproperty ≥ 1 (e.g. Key Takeaways).You should be able to delete the element (by hitting CMD + A and backspace, not the controls as these are disabled).
Deleting the element will wipe all its content but crucially keep a repeater with one empty child.
The document should save as normal and fire no error messages.