Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make list element title and content fields align with body in Composer #375

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

rhystmills
Copy link
Contributor

What does this change?

Makes some minor tweaks to nestedElement field and altStyle wrapper to make sure the list element title and content align with the main editor text in Composer. They were once aligned but there has been some drift.

Before After
image image

How to test

  1. Use yarn yalc in this repo to publish prosemirror-elements locally.
  2. Use it in the composer directory of flexible-content with yalc add @guardian/prosemirror-elements
  3. Create one of the list elements and check out the alignment.

@rhystmills rhystmills requested a review from a team as a code owner March 26, 2024 15:57
Copy link
Contributor

@simonbyford simonbyford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was very jarring, thank you

@rhystmills rhystmills merged commit 8b9974f into main Mar 28, 2024
3 checks passed
@rhystmills rhystmills deleted the rm/alt-style-element-spacing branch March 28, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants