Remove double border between nested fields and text fields #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhystmills
changed the title
… affect all nested fields, which is fine for now but might need a more nuanced solution in the future if nested fields are not below a text field. Co-authored-by: Simon Byford <simon.byford@guardian.co.uk>
simonbyford
force-pushed
the
sb-rm/double-border
branch
from
8c3b070
to
a0d4e38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored with @simonbyford.
We thought we'd have another pop at this to see if we could avoid the side effects in https://github.com/guardian/flexible-content/pull/4704
This time around, we've used outlines rather than borders to avoid layout shifts when we apply the styles, and to make sure validation and focus states are always 'above' the existing borders.
Before:
After:
How to test
Pull this branch into composer locally with
yalcand check that this is working properly in one of the list elements.