Fix prosemirror-noting bugs by passing storedMarks to inner editor, and passing up paste meta

[rhystmills]

What does this change?

We have encountered a few bugs related to the interaction of nested fields with notes from @guardian/prosemirror-noting - specifically:

1. Typing in the first or final character of a note doesn't extend it
2. Pasting into a note doesn't apply the note mark to the pasted characters
3. Moving over the note boundary via key presses skips a character

This PR fixes these issues by making some changes to the ProsemirrorFieldView:

1. Passes in storedMarks defined by the outer editor to the inner editor, applying them on the next transaction in the inner editor. The note extension functionality is managed by storedMarks, rather than by setting an inclusive attribute on the mark, as we see with something like strong or em marks. Until now, we haven't passed stored marks from the outer editor to our fields.
2. Swaps the order in which we update the inner and outer editor in dispatchTransaction - we now update the inner editor first, then update the outer editor.

The existing order of operations here was leading to some issues with my storedMarks work.

When a user moved their cursor in a note within a text field: the inner editor dispatched a transaction, the outer editor (which has the copy of the prosemirror-noting plugin, and therefore 'knows' about the note) would then introduce a stored mark representing the note mark, which was passed into the plugin. The inner state change would then finish, with no knowledge of the intermediate transaction from the outer editor that had occurred, effectively ignoring the introduced stored mark.

Now, the inner transaction is dispatched, then the outer editor transaction is dispatched, including the stored mark, and it can be applied on the next transaction (e.g. a typed character).

This change also fixed the 'moving over a note boundary' issue.

3. Passes 'paste' meta to the outer editor. prosemirror-noting uses this to identify transactions that are pastes within a note, and apply the note mark to them.

Noting without these changes:

Noting with the change:

How to test

Run the tests, I've added some.
You may want to test in Composer via yalc to test the noting behaviour specifically.

[jonathonherbert]

This looks great. The tests are really clear.

There are a few non-blocking comments. Lots of value here so keen to let you 🚢 at a cadence which makes sense for stakeholders!

Also non-blocking: ideally each fix would belong in its own PR, which would making managing reverting easier if there were problems downstream for those that don't know the code so well.

[jonathonherbert]

Nice to DRY up this repetition! 👍

[rhystmills]

Also non-blocking: ideally each fix would belong in its own PR, which would making managing reverting easier if there were problems downstream for those that don't know the code so well.

I will bear the separation of fixes in mind next time - would be keen to get this one out though as it's affecting users of the formats in production at the moment!