Fix selection error when backwards selections cover fields #410
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes an error where backwards selections that extend beyond a field are passed into the field view, causing range errors.
The errors are largely harmless – they're a no-op on the state and do not halt the outer editor – but they're causing some noise in our downstream CMS's error reporting.
There's a question as to whether fields should be aware of selections that cover them entirely. I don't think we've seen a use case yet, but we could map and clamp the selection values, rather than just ignoring, if we wanted that behaviour.
How to test