Merge pull request #29 from guardian/jsh/no-debug-ranges

Don't add debug decorations on error unless debug is enabled
guardian · Jan 27, 2019 · 3487a4e · 3487a4e
2 parents 52af2d9 + d0a3cdd
commit 3487a4e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/ts/state.ts b/src/ts/state.ts
@@ -605,7 +605,7 @@ const handleValidationRequestError = <
   // validated on the next pass.
   let decorations = state.decorations.remove(decsToRemove);
 
-  if (dirtiedRanges.length) {
+  if (dirtiedRanges.length && state.debug) {
     decorations = decorations.add(
       tr.doc,
       dirtiedRanges.map(range => createDebugDecorationFromRange(range))

diff --git a/src/ts/test/state.spec.ts b/src/ts/test/state.spec.ts
@@ -324,9 +324,7 @@ describe("State management", () => {
               to: 25
             }
           ],
-          decorations: new DecorationSet().add(initialDocToValidate, [
-            createDebugDecorationFromRange({ from: 1, to: 25 })
-          ]),
+          decorations: new DecorationSet(),
           error: "Too many requests",
           validationInFlight: undefined
         });