fix: Keep track of dirty ranges when requests are inflight so they supercede incoming matches #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
jsh/do-not-allow-matches-that-fall-outside-doc
to
main
December 13, 2021 11:28
jonathonherbert
force-pushed
the
jsh/keep-dirtied-ranges-whilst-checks-are-inflight
branch
from
08ac996
to
8f681f2
Compare
SHession
approved these changes
Jan 6, 2022
|
🎉 This PR is included in version 5.11.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
jonathonherbert
deleted the
jsh/keep-dirtied-ranges-whilst-checks-are-inflight
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
When Typerighter's operating in realtime mode (
requestMatchesOnDocModified = true), it keeps track of dirtied ranges, and ensures that any ranges dirtied whilst a request for that range is in flight invalidate matches made in that request.In non-realtime mode, it ... doesn't. See #189.
This change corrects that oversight, ensuring that dirtied ranges are tracked whilst requests are in flight. Once the request is complete,
dirtiedRangesis reset, and ranges are no longer tracked.How to test