fix: Handle telemetry send errors #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like there is quite a lot of changes in this PR outside of the description provided. I would recommend making the service change in the new repo and I wonder if this error logs could be related to this Composer PR. |
|
Yep, this is now in the wrong place after #198 – closing in favour of opening a PR in the relevant repository. Some of this may well be caused by the problem you mention in that PR – regardless of the provenance of the errors, probably best to catch them w/in the client. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Handle telemetry send errors, which are currently unhandled and clutter our Sentry instrumentation.
How to test
Introduce a network error when telemetry events are sent, perhaps by turning off the browsers network access by any means and running a document check.
You should see
warnlog messages, but no unhandled errors.How can we measure success?
Fewer unhandled errors cluttering our Sentry logs in our consumer CMS.