chore: Fix setup script to run project locally #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathonherbert
approved these changes
Jul 12, 2022
jonathonherbert
changed the title
Co-authored-by: Jonathon Herbert <jonathon.herbert@guardian.co.uk>
|
🎉 This PR is included in version 5.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
jonathonherbert
added a commit
that referenced
this pull request
Jul 13, 2022
* fix set-up script * fixing url for local dev * Update docs/README.md Co-authored-by: Jonathon Herbert <jonathon.herbert@guardian.co.uk> Co-authored-by: Jonathon Herbert <jonathon.herbert@guardian.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
The
./setup.shscript wasn't working as it was failing to find the nginx mapping. This PR fixes the script and updates the README with up-to-date instructions on getting this project running locally.How to test
Run the set-up script and it should find the nginx mapping file.