feat: Add a 'dev mode' flag to the view, and a few developer utilities #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathonherbert
force-pushed
the
jsh/add-dev-mode
branch
from
cff46d2
to
ea710e2
Compare
jonathonherbert
force-pushed
the
jsh/add-dev-mode
branch
2 times, most recently
from
532f6cf
to
736c312
Compare
…ed (#210) * Allow enabling real-time checking when the plugin is instantiated * Add test * Reference IPluginConfig directly in IPluginOptions Allow enabling real-time checking when the plugin is instantiated Don't remove debug decorations when filtering decorations Add test Reference IPluginConfig directly in IPluginOptions
Allow enabling real-time checking when the plugin is instantiated Reference IPluginConfig directly in IPluginOptions
jonathonherbert
force-pushed
the
jsh/add-dev-mode
branch
from
736c312
to
178083e
Compare
src/ts/components/Controls.tsx
Outdated
| type="checkbox" | ||
| id="debug" | ||
| checked={debug} | ||
| onChange={() => setDebugState(!debug)} |
There was a problem hiding this comment.
debug is quite a generic term, could we rename this to something more specific? setShowPendingInflightChecks?
|
@rebecca-thompson hm not removing those ranges is a bit lazy – thanks for noticing, let's remove them. |
rebecca-thompson
approved these changes
Jul 19, 2022
|
🎉 This PR is included in version 5.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a 'dev mode' parameter to the view function, which when
truepresents the user with two checkboxes that permit:Pending checks are only really relevant in real time mode – they represent the ranges that have been 'dirtied' since the last check, and are due to be sent to Typerighter. In-flight checks have been sent to Typerighter and have not yet come back.
Here's how the UI looks:
And here's the annotations at work, with an explanation:
I've defaulted dev mode to true in the sandbox – hopefully that makes sense.
How to test
Fire up prosemirror-typerighter locally and have a play. Does it behave as expected? Do you think these things will be useful?