fix: Tweak to center info icon #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💎 |
dskamiotis
approved these changes
Aug 22, 2022
| @@ -54,13 +54,11 @@ export const getPopperConfig = ( | |||
| }; | |||
|
|
|||
| const tooltipIconView = css` | |||
| padding: 2px; | |||
| height: 20px; | |||
| height: 18px; | |||
There was a problem hiding this comment.
I think the padding had n impact in the i being very slightly off centre.
This seems to have done the trick :)
|
🎉 This PR is included in version 5.20.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
A small tweak to keep the information icon added in #217 centered in our consuming CMS.
Quite subtle – I've adjusted the position of the icon so it should be dead centre, and removed the gray border above the coloured banner, which in my eyes altered the perception of central-ness for the icon.
How to test
Take a look at the screenshots, or run locally. (Test in Composer is possible via the instructions in the readme.) Do you get a sense of ... geometric harmony?