feat: Read percentage complete from Typerighter API response when available #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathonherbert
approved these changes
Sep 23, 2022
There was a problem hiding this comment.
As with the review of guardian/typerighter#204, I haven't been able to exercise this, but code looks good 👍
|
Tested locally, works as expected. |
Co-authored-by: Jonathon Herbert <jonathon.herbert@guardian.co.uk>
|
🎉 This PR is included in version 5.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This reads an optional parameter returned by the Typerighter API which indicates what percentage of a request has been completed in the streamed/chunked response. There is currently a lot of logic in this project which calculates the percentage remaining based on the number of processed vs inflight requests. The ultimate goal is that a lot of that code will be able to be removed once we move over to using the chunked Typerighter Adapter.
How to test
Deploy and run this branch locally and run the accompanying branch in typerighter. You should be able to see the loading bar in the right hand side results panel continue to work as expected.