fix: Add spellcheck=false to match decorations #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathonherbert
commented
Nov 7, 2022
| @@ -66,7 +66,7 @@ const { | |||
| typerighterTelemetryAdapter.matchDecorationClicked(match, document.URL), | |||
| requestMatchesOnDocModified: true, | |||
| adapter: new TyperighterChunkedAdapter( | |||
| "https://checker.typerighter.local.dev-gutools.co.uk" | |||
There was a problem hiding this comment.
Not strictly related but added as part of this PR – it's much more likely developers are working with the CODE sandbox when developing PM-TR locally, and I'm forever correcting when making PRs!
alinaboghiu
approved these changes
Nov 9, 2022
|
🎉 This PR is included in version 6.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Disable browser spellchecking in matched text.
How to test
Running locally, and making sure your browser's spellcheck is on, introduce some words to the sandbox that result in a hit from the spellcheck and Typerighter simultaneously ('Keir Starmer' does the trick for the basic spellcheck in Chrome.) They should match the result above.