Poll PRs even after they're overdue #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users found it confusing that Prout wasn't polling PRs after they were overdue: guardian/membership-frontend#538 (comment) Note that for guardian/membership-frontend, the post-deploy hook from RiffRaff hits Prout after the deploy 'completes', but I think sometimes the site is still serving old content (due to caching and Fastly) a little bit longer. When Prout scanned the site after the deploy, it still had the old commit: 2015-05-20T13:46:05.746475+00:00 app[web.1]: [ESC[37minfoESC[0m] application - guardian/membership-frontend has 1 active snapshots : Map(PROD -> b43457b7) https://riffraff.gutools.co.uk/deployment/view/9276b501-68a4-491c-9a18-844fa73289c4# [14:45:58] task ResumeAlarmNotifications Resuming Alarm Notifications - group will scale on any configured alarms We have a cache time of 1 minute on the front page, so it's not too surprising that it would be serving the old version of the site - RiffRaff just feels that the deploy is done, because the ASG/ELB have stabilised, but we have a slightly different definition :-)
|
Not familiar enough with the code to have much of an opinion on correctness, but definitely a 👍 for the sentiment. |
rtyley
added a commit
that referenced
this pull request
May 20, 2015
…rdue Poll PRs even after they're overdue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users found it understandably confusing that Prout wasn't polling PRs after they were overdue:
guardian/membership-frontend#538 (comment)
Note that for guardian/membership-frontend, the post-deploy hook from RiffRaff hits Prout after the deploy 'completes', but I think sometimes the site is still serving old content (due to caching and Fastly) a little bit longer. When Prout scanned the site after the deploy, it still had the old commit (guardian/membership-frontend@b43457b7):
https://riffraff.gutools.co.uk/deployment/view/9276b501-68a4-491c-9a18-844fa73289c4#
We have a cache time of 1 minute on the front page, so it's not too surprising that it would be serving the old version of the site - RiffRaff just feels that the deploy is done, because the ASG/ELB have stabilised, but we have a slightly different definition :-)
cc @philwills @davidrapson