Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix setup-java action - remove sbt caching #68

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

rtyley
Copy link
Member

@rtyley rtyley commented Mar 14, 2024

See #67 (comment) - this does fix the setup-java config, which is good.

rtyley added a commit to guardian/mobile-save-for-later that referenced this pull request Mar 14, 2024
See guardian/scala-steward-public-repos#68 ...
we're now running our Scala Steward workflow with Java 21 LTS, which
means that all projects that want to have Scala Steward updates (like
https://github.com/guardian/mobile-save-for-later) need to be able
to build under Java 21 (even if the projects are still _running_ in
production on Java 8).

Being able to build with Java 21 requires using recent versions of
Scala (2.12.18+) and sbt (1.9.0+):

https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html#jdk-21-compatibility-notes
Copy link
Member

@johnduffell johnduffell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for picking that up so quickly! Didn't think about there being no sbt cache for the project itself, of course scala steward is a bit special in how it works! 👍

@rtyley rtyley merged commit 5749823 into main Mar 15, 2024
1 check failed
@rtyley rtyley deleted the fix-setup-java-action branch March 15, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants