Upgrade to Typescript 4.9.5 and set as peerDependency of generated package
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieB-gu
approved these changes
Mar 7, 2023
rtyley
changed the base branch from
main
to
db-rt/updating-to-gh-scala-lib-release
rtyley
force-pushed
the
db-rt/updating-to-gh-scala-lib-release
branch
from
6bc9764
to
75e6d07
Compare
Typescript doesn't follow semantic versioning (microsoft/TypeScript#39269). This means that there could be breaking changes in caret (`^`) ranges. This change: - upgrades to Typescript 4.9.5 for building the typescript files - adds Typescript ~4.9.5 as a `peerDependency` of the generated npm package - adds a `scroogeTypescriptPeerDependencies` setting to enable plugin users to add peer dependencies to the `package.json` - fixes a mismatched type in the `decode-encode` module
rtyley
force-pushed
the
gb/typescript-tilde-peerdep
branch
from
798cbd8
to
83e8d19
Compare
|
@georgeblahblah just to let you know, I've rebased this PR on top of #31 (to add CI) and #30 (to allow publishing a preview release that can be tried out on a consumer of the As you can see in the comment above, this PR fixes the tests and CI passes! |
|
Closing this for now as it's stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Typescript doesn't follow semantic versioning (microsoft/TypeScript#39269). This means that there could be breaking changes in caret (
^) ranges.This change:
peerDependencyof the generated npm packagescroogeTypescriptPeerDependenciessetting to enable plugin users to add peer dependencies to thepackage.jsondecode-encodemoduleHow to test
sbt test