Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Java 11 #413

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Move to Java 11 #413

merged 2 commits into from
Feb 23, 2022

Conversation

jfsoul
Copy link
Contributor

@jfsoul jfsoul commented Feb 22, 2022

What does this change?

Updates to Java 11, which the Guardian's Play Secret Rotation library ultimately depends on (via https://github.com/guardian/play-secret-rotation/blob/main/build.sbt#L18) on https://github.com/ben-manes/caffeine/releases/tag/v3.0.0.

Copy link
Contributor

@jacobwinch jacobwinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably worth mentioning this in the README too, as we currently have some apps which still use Java 8 and others which require Java 11.

@jfsoul jfsoul force-pushed the js/java-11 branch 2 times, most recently from 5c08d4f to 785a31a Compare February 23, 2022 09:19
@jfsoul jfsoul merged commit 1f12562 into main Feb 23, 2022
@jfsoul jfsoul deleted the js/java-11 branch February 23, 2022 10:24
rtyley added a commit to guardian/janus-app that referenced this pull request May 21, 2024
Although we're _building_ with Java 21, we're also updating the minimum supported
Java version from Java 8 to Java 11:

#442 (review)

We can do this because the artifact published by this repo:

"com.gu" %% "janus-config-tools" % "1.0.0"
https://index.scala-lang.org/guardian/janus-app/artifacts/janus-config-tools

...is only consumed by these two apps, Janus & Security HQ:

* guardian/janus#3947
* guardian/security-hq#413

....both of which are now running on Java 11.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants