Move to Java 11 #413
Merged
Move to Java 11 #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobwinch
approved these changes
Feb 22, 2022
jfsoul
force-pushed
the
js/java-11
branch
2 times, most recently
from
5c08d4f
to
785a31a
Compare
rtyley
added a commit
to guardian/janus-app
that referenced
this pull request
May 21, 2024
Although we're _building_ with Java 21, we're also updating the minimum supported Java version from Java 8 to Java 11: #442 (review) We can do this because the artifact published by this repo: "com.gu" %% "janus-config-tools" % "1.0.0" https://index.scala-lang.org/guardian/janus-app/artifacts/janus-config-tools ...is only consumed by these two apps, Janus & Security HQ: * guardian/janus#3947 * guardian/security-hq#413 ....both of which are now running on Java 11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates to Java 11, which the Guardian's Play Secret Rotation library ultimately depends on (via https://github.com/guardian/play-secret-rotation/blob/main/build.sbt#L18) on https://github.com/ben-manes/caffeine/releases/tag/v3.0.0.