Tidy repo now that Cloudquery has taken over #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akash1810
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
🤩
We can very likely drop the use of NPM workspaces to further simplify this repository. Suggest doing this separately though, as this PR is big already.
Riff-Raff doesn't delete CFN stacks, so I think we'd have to manually delete them. Wonder if there are any AMIgo recipes that can be removed now too?
Previous packages: - cdk - cloudquery (dev) - common - github-data-fetcher - github-lens-api - repocop - services-api Now: - ckd - cloudquery - repocop There is some discussion to be had about whether Repocop still belongs here or should live elsewhere, in which case this repo would be solely focused on Cloudquery.
|
@akash1810 stacks (and load balancers) deleted. The AMIs seem to be general ones so have left those for now. |
akash1810
added a commit
that referenced
this pull request
Jun 7, 2023
RepoCop as a service uses the GitHub Lens API as its source of data. In #202, we deleted the GitHub Lens API. This means in its current form, RepoCop is failing to run. Remove the service for a later day.
|
I have removed the GitHub App named |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO - re-add bits to main README on local dev and tidy the setup script.
What does this change?
Previous packages:
Now:
There is some discussion to be had about whether Repocop still belongs here or should live elsewhere, in which case this repo would be solely focused on Cloudquery.
Why?
To remove stuff we no longer plan to develop.
How has it been verified?
CI tests only.