-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update palette colours #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in this file are to create a bottom sheet scaffold. The bottom sheet is used to display the palette when "Open Palette" button is clicked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Colour changes are in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this xml file from news app and updated colours in it too. This will replace the file in source module in the news app.
Hi Adi, All the colours look good apart from the opinion of 300 and missing Special Report and Special Report Alt colours.
https://docs.google.com/document/d/1chQ2EqUdkjvzqn8hHgAthCL84M-XWeQ2hQg0_BsrBsg/edit |
On web we have |
Hi @jamesmockett, The Special report colours are correct in Source, so I will let Adi know about the additional colours. |
Hi @ab-gnm, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Updates palette colours based on @akemitakagi 's feedback document.
I've left the
opinion_300
in but marked it as deprecated with recommendation to use 400 instead.Also added a sheet with all palette pills to the sample app (screenshot below).
Testing notes/instructions:
Build and run the sample app to see all the palette colours, and maybe confirm them with Akemi's sheet.
Checklist
Recommended reviewiers
For pull requests introducing UI changes:
Screenshots or videos: