Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add button variant that allows custom colours #52

Merged
merged 12 commits into from
Jun 11, 2024
Merged

Add button variant that allows custom colours #52

merged 12 commits into from
Jun 11, 2024

Conversation

ab-gnm
Copy link
Member

@ab-gnm ab-gnm commented Jun 6, 2024 •
edited
Loading

Description

Created PlainSourceButton and PlainSourceContentButton variants. These take a ButtonColours object instead of theme and priority. They are intended to be used for custom colour combinations.

Testing notes/instructions:

Check out the unthemed button in sample.

Checklist

  • Changes have been checked by the developer
  • Changes have been checked by the reviewers
  • Unit tested
Recommended reviewiers
  • Design review for UI changes from @guardian/design-system
  • Code review from @guardian/android-developers or @guardian/ios-developers
  • Optional code/API review from @guardian/client-side-infra
Specific notes/instructions for the reviewer:

For pull requests introducing UI changes:

  • Sign-off by Design:
  • Dark Mode
  • Tablet
  • Accessibility (e.g. VoiceOver):
Screenshots or videos:
Before After
Light
Dark

@ab-gnm ab-gnm added the Android Android specific PRs label Jun 6, 2024
@ab-gnm ab-gnm marked this pull request as ready for review June 6, 2024 16:10
@ab-gnm ab-gnm requested a review from a team as a code owner June 6, 2024 16:10
@ab-gnm ab-gnm changed the base branch from main to ab/update-colour-palettes June 6, 2024 21:40
@ab-gnm
Merge branch 'ab/update-colour-palettes' into ab/add-button-variants-…
65eec7b 
…with-colour-overrides

# Conflicts:
#	android/sample/src/main/kotlin/com/gu/source/MainActivity.kt
@ab-gnm
Merge branch 'ab/update-colour-palettes' into ab/add-button-variants-…
f41c692 
…with-colour-overrides
Base automatically changed from ab/update-colour-palettes to main June 11, 2024 10:32
frankie297
frankie297 approved these changes Jun 11, 2024
View reviewed changes
Copy link

@frankie297 frankie297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ab-gnm ab-gnm added this pull request to the merge queue Jun 11, 2024
Merged via the queue into main with commit 4ee22d8 Jun 11, 2024
6 checks passed
@ab-gnm ab-gnm deleted the ab/add-button-variants-with-colour-overrides branch June 11, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankie297 frankie297 frankie297 approved these changes

Assignees

@frankie297 frankie297

Labels
Android Android specific PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ab-gnm @frankie297