Make -x (execute) the default behaviour #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR modifies ssm-scala so that you no longer need to pass
-xor--executein order to get it to execute the ssh command.In 7 years of using SSM, I don't think I have ever wanted to run a command without
-x. The only use case has been for scripts which have made use of--rawto build a more complex ssh command. With that in mind, I have modified the--rawsetting so that it now disables execution.This PR introduces a new 'dryrun' command line option as a way of getting the old behaviour back (printing out the ssh command rather than executing).
As this affects the default behaviour of SSM I this will need to be at least a minor version bump and I'll send out some comms as well after releasing.
What is the value of this?
Two characters less typing every time anyone uses SSM. Only 2 characters! So best not to think about this PR too much or it will take another year to pay off!
Any additional notes?