This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
chore: Add snyk monitoring for main branch #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinPinner
approved these changes
Jul 20, 2022
There was a problem hiding this comment.
This appears reasonable but I wonder what it'll actually monitor. As a publishing mechanism for thrift models, I think that means that other than sbt plugins, we don't have many/any other dependencies. If we're ok with this I don't see a reason not to apply it though, so will approve anyway.
|
There's still a few dependencies that are worth tracking. You can see what it will look like in the screenshot below. I would agree that this is probably a fairly low priority project, but our aim is 100% coverage. That will give better visibility, at which point we can make smarter decisions about how to prioritise projects.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reliably integrates the repository with the snyk GitHub action which will scan your code’s dependencies and alert you if vulnerabilities are found. This PR has only been raised on repos that have already been tested to make sure scanning will work out of the box. ‘reliably integrated’ means that this action compares the hash of the last commit on main to the one that snyk has, and makes sure that they match.