Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show spinner until state retrieved from server #44

Merged
merged 1 commit into from Sep 13, 2019
Merged

Show spinner until state retrieved from server #44

merged 1 commit into from Sep 13, 2019

Conversation

tomrf1
Copy link
Member

@tomrf1 tomrf1 commented Sep 13, 2019 •
edited

Currently the 'Edit' button is displayed until state comes back from the server. Instead, show a spinner.
Also, I've moved previousStateFromServer into the component's state.

Screenshot 2019-09-13 at 10 13 53

jlieb10
jlieb10 approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@jlieb10 jlieb10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice work

@tomrf1 tomrf1 merged commit 2ae953e into master Sep 13, 2019
@tomrf1 tomrf1 deleted the tf-epic-loading branch September 13, 2019 10:17
tjsilver
tjsilver reviewed Sep 13, 2019
View reviewed changes
Copy link
Contributor

@tjsilver tjsilver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjsilver tjsilver tjsilver left review comments

@jlieb10 jlieb10 jlieb10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomrf1 @jlieb10 @tjsilver