Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add investigations moment banner #525

Merged
merged 14 commits into from Sep 24, 2021
Merged

Add investigations moment banner #525

merged 14 commits into from Sep 24, 2021

Conversation

tompretty
Copy link
Contributor

What does this change?

Add investigations moment banner Trello card

Images

mobile
Screenshot 2021-09-21 at 15 21 55

tablet
Screenshot 2021-09-21 at 15 22 45

desktop
Screenshot 2021-09-21 at 15 22 59

leftcol
Screenshot 2021-09-21 at 15 23 13

wide
Screenshot 2021-09-21 at 15 23 28

@@ -172,6 +172,7 @@ const withBannerData = (
email,
tickerSettings,
isSupporter,
numArticles,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needed to be passed through to so the investigations banner can render the special opt out subheading

@tompretty tompretty force-pushed the tp-investigations-banner branch 3 times, most recently from f48a505 to d38b353 Compare September 23, 2021 09:12
Copy link
Member

@tomrf1 tomrf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! Looks good on ff/chrome/safari

@tompretty tompretty merged commit ce9eb2f into main Sep 24, 2021
@tompretty tompretty deleted the tp-investigations-banner branch September 24, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants