Make primary CTA on thank you page solid #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! One small/separate, but connected thing to check: the "Please tell us..." text should be the same as the "Subscriptions, membership and contributions". Please could you check type size / line height / weight and make sure they're consistent? @johnduffell |
|
thanks @ionamckendrick , I have updated the default colour for the whole page to be garnett-neutral-1 i.e. 121212 rather than 333333. See the edited screenshot in the description above. |
akash1810
approved these changes
Dec 10, 2018
|
Seen on PROD (merged by @johnduffell 10 minutes and 55 seconds ago)
Sentry Release: support-client-side, support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you doing this?
The main cta on a page should be solid for usability reasons. The supplementary ones should generally be hollow. In the thank you page the Share your thoughts is the main one, although the sign up to email one is also kind of main so can remain solid.
Trello Card
Before:
After:
@ionamckendrick I think I covered the things you described, please let me know if I forgot any of the tweaks!