Price summary updates #1857
Merged
Price summary updates #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupertbates
force-pushed
the
price-summary-updates
branch
from
f68f320
to
af37867
Compare
lucymonie
reviewed
Jun 10, 2019
| @@ -81,7 +78,12 @@ const hasDiscount = (promotion: ?Promotion): boolean %checks => | |||
| promotion !== undefined && | |||
| isNumeric(promotion.discountedPrice); | |||
|
|
|||
| function applyDiscount(price: Price, promotion: ?Promotion) { | |||
| const hasIntroductoryPrice = (promotion: ?Promotion): boolean %checks => | |||
There was a problem hiding this comment.
What does the % do in this line? I haven't seen this before.
There was a problem hiding this comment.
It is to tell Flow that this is a check, some details (though not many) here: facebook/flow#4723
lucymonie
approved these changes
Jun 10, 2019
|
Seen on PROD (merged by @rupertbates 13 minutes and 37 seconds ago)
Sentry Release: support-client-side, support |
|
✅ Testing in PROD passed! Details |
This was referenced Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you doing this?
We have previously had two types which describe subs product prices;
Pricewhich had the price and the currency andProductPricewhich had the price and any promotions which were applied.This led to a lot of code mapping between the two and made things complicated when trying to unify the pricing code across components. I have now merged the two types into
ProductPricewhich contains all the fields and used this throughout the subs components.This has also improved the summary component which didn't really cope with 6 for 6 properly before.
Trello Card