Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic checkout: zip-code & state validation #5998

Merged
merged 9 commits into from May 15, 2024

Conversation

paul-daniel-dempsey
Copy link
Contributor

@paul-daniel-dempsey paul-daniel-dempsey commented May 10, 2024

Part of #5722

What are you doing in this PR?

State & ZipCode validation for the Generic Checkout

State ZIP Code
image image

Trello Card

@paul-daniel-dempsey paul-daniel-dempsey requested a review from a team May 10, 2024 16:58
Copy link
Contributor

github-actions bot commented May 10, 2024

Size Change: +281 B (+0.01%)

Total Size: 1.98 MB

ℹ️ View Unchanged
Filename Size Change
./public/compiled-assets/javascripts/[countryGroupId]/router.js 186 kB +141 B (+0.08%)
./public/compiled-assets/javascripts/ausMomentMap.js 107 kB 0 B
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 217 kB +82 B (+0.04%)
./public/compiled-assets/javascripts/downForMaintenancePage.js 68.1 kB 0 B
./public/compiled-assets/javascripts/error404Page.js 68 kB 0 B
./public/compiled-assets/javascripts/error500Page.js 68 kB 0 B
./public/compiled-assets/javascripts/favicons.js 616 B 0 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 168 kB 0 B
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 84.8 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPage.js 66.6 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./public/compiled-assets/javascripts/promotionTerms.js 71.3 kB 0 B
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 70.4 kB 0 B
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 124 kB 0 B
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 285 kB +58 B (+0.02%)
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 189 kB 0 B
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 85.1 kB 0 B
./public/compiled-assets/webpack/385.js 81.8 kB 0 B
./public/compiled-assets/webpack/735.js 2 kB 0 B
./public/compiled-assets/webpack/775.js 18 kB 0 B
./public/compiled-assets/webpack/864.js 18.3 kB 0 B
./public/compiled-assets/webpack/991.js 2.16 kB 0 B

compressed-size-action

@paul-daniel-dempsey paul-daniel-dempsey force-pushed the generic-checkout-state-zipcode-validation branch from cbc783d to 0bd40f9 Compare May 10, 2024 17:12
Copy link
Contributor

@jamesgorrie jamesgorrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions - main one is around code clarity on billingState.

@paul-daniel-dempsey paul-daniel-dempsey merged commit 64b41db into main May 15, 2024
15 checks passed
@paul-daniel-dempsey paul-daniel-dempsey deleted the generic-checkout-state-zipcode-validation branch May 15, 2024 11:19
@prout-bot
Copy link

Seen on PROD (merged by @paul-daniel-dempsey 10 minutes and 52 seconds ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants