New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic checkout: zip-code & state validation #5998
Merged
paul-daniel-dempsey
merged 9 commits into
main
from
generic-checkout-state-zipcode-validation
May 15, 2024
Merged
Generic checkout: zip-code & state validation #5998
paul-daniel-dempsey
merged 9 commits into
main
from
generic-checkout-state-zipcode-validation
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +281 B (+0.01%) Total Size: 1.98 MB ℹ️ View Unchanged
|
paul-daniel-dempsey
force-pushed
the
generic-checkout-state-zipcode-validation
branch
from
May 10, 2024 17:12
cbc783d
to
0bd40f9
Compare
jamesgorrie
reviewed
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of questions - main one is around code clarity on billingState
.
support-frontend/assets/components/personalDetails/stateSelect.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: James Gorrie <jamesgorrie@users.noreply.github.com>
jamesgorrie
approved these changes
May 15, 2024
Seen on PROD (merged by @paul-daniel-dempsey 10 minutes and 52 seconds ago)
Sentry Release: support-client-side, support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5722
What are you doing in this PR?
State & ZipCode validation for the Generic Checkout
Trello Card