remove commented code and add explanation

guardian · Jul 6, 2021 · 20583c0 · 20583c0
1 parent 324ba4c
commit 20583c0
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/handlers/revenue-recogniser-job/src/main/scala/com/gu/recogniser/Handler.scala b/handlers/revenue-recogniser-job/src/main/scala/com/gu/recogniser/Handler.scala
@@ -112,10 +112,7 @@ class Steps(
       undistributedScheduled <- revenueSchedulesQuerier.execute()
       (revenueSchedulesToDistributeToday, revenueSchedulesToDistributeRange) = partitionSchedules.partition(undistributedScheduled)
       _ <- distributeForQueryRow(revenueSchedulesToDistributeToday, revenueSchedulesToDistributeRange)
-//      _ = log("now query again and assert there are none")
-//      stillUndistributedRevenue <- revenueSchedulesQuerier.execute()
-//      numberNotDone = stillUndistributedRevenue.to(LazyList).length
-//      _ <- if (numberNotDone > 0) Left(s"there were still revenue schedules: $numberNotDone") else Right(())
+      // would be nice to confirm success by querying zuora again, or cross check against the number of unredeemed subs
     } yield ()
 
   }