Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reformated catalog json slightly #169

Merged
merged 4 commits into from Aug 3, 2018
Merged

reformated catalog json slightly #169

merged 4 commits into from Aug 3, 2018

Conversation

pvighi
Copy link
Contributor

@pvighi pvighi commented Aug 3, 2018

added all the window params into its own json object

@pvighi pvighi requested a review from johnduffell August 3, 2018 11:59
@coveralls
Copy link

coveralls commented Aug 3, 2018

Pull Request Test Coverage Report for Build 107

  • 0 of 8 (0.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.2%) to 73.134%

Changes Missing Coverage Covered Lines Changed/Added Lines %
handlers/new-product-api/src/main/scala/com/gu/newproduct/api/productcatalog/Handler.scala 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
lib/handler/src/main/scala/com/gu/util/apigateway/ApiGatewayRequest.scala 1 64.71%
lib/handler/src/main/scala/com/gu/util/apigateway/ApiGatewayHandler.scala 1 80.95%
lib/zuora-reports/src/main/scala/com/gu/zuora/reports/ReportsLambda.scala 1 57.14%
src/main/scala/com/gu/stripeCustomerSourceUpdated/SourceUpdatedSteps.scala 1 80.0%
handlers/sf-contact-merge/src/main/scala/com/gu/sf_contact_merge/update/UpdateAccountSFLinks.scala 1 80.0%
Totals Coverage Status
Change from base Build 99: -0.2%
Covered Lines: 1274
Relevant Lines: 1742

💛 - Coveralls

@guardian guardian deleted a comment Aug 3, 2018
)
case class StartDateRules(
daysOfWeek: Option[List[DayOfWeek]] = None,
selectableWindowRules: Option[SelectableWindowRules] = None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waitch out for training commas, as it prevents the scala formatter from working

...which may be a good thing depending on your opinion 😆

| "cutOffDayInclusive": "Tuesday",
| "minDaysAfterCutOff" : 20,
| "windowSizeDays" : 28,
| "selectableWindowRules" : {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the word 'Rules' useful in this name?

| "windowSizeDays" : 28,
| "selectableWindowRules" : {
| "cutOffDayInclusive": "Tuesday",
| "minDaysAfterCutOff" : 20,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that we're in the "selectable window" context, this is actually the start of the window. So maybe startDaysAfterCutoff? or daysBetwenCutoffAndStart

@johnduffell
Copy link
Member

great just a couple of comments now that the context has changed for the names but other than that definitely better
👍

@guardian guardian deleted a comment Aug 3, 2018
@guardian guardian deleted a comment Aug 3, 2018
@johnduffell
Copy link
Member

👍 🚀

@pvighi pvighi merged commit 3dab31a into master Aug 3, 2018
@pvighi pvighi deleted the catalog_3 branch August 3, 2018 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants