-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compile and run against java 21 LTS #2195
Conversation
@@ -9,7 +9,6 @@ val scala2Settings = Seq( | |||
"-encoding", | |||
"UTF-8", | |||
"-feature", | |||
"-target:jvm-1.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this parameter was causing a lot of warnings, also it wasn't really relevant any more. It would only be needed if we were compiling on a later VM and running on an earlier one.
sys.props("java.specification.version") == "21", | ||
"Java 21 is required for this project, download corretto-21 from File->Project structure.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen problems locally where people have been on a later version than is supported by either SBT/play/scala, so I have kept this in and updated it.
If it's causing issues locally we can rethink.
Looks like we need to bump the version of Java used by our Scala Steward workflow as well: https://github.com/guardian/scala-steward-public-repos/actions/runs/8278707245/job/22651625930
|
good spot @rtyley I have raised a PR to update scala steward, however it is likely to fail on other projects where they are not up to recent versions of sbt, it's needing 2.12.18 or later to work https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html |
Further to updating to arm64 architecture #2194
This PR updates to java 21 LTS. This seems to have bumped performance significantly with support-workers guardian/support-frontend#5792 , so I am replicating it here.
I have also bumped the version we compile with in GHA, in case that improves compilation performance.
I tested auto cancel in CODE and it seems to have improved the cold start noticably